revert scrollwindow patches breaking function wizard (master) #9926
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…to 'scrollWidth' in the _scrolledWindowControl function" This reverts commit 15ffda9. Related to issues #9614 #9559 #9770 Signed-off-by: Szymon Kłos <[email protected]> Change-Id: I19d44db2252de91c0ca637256239d4a9405e1c31
This reverts commit fd35bd7. Related to issues #9614 #9559 #9770 Signed-off-by: Szymon Kłos <[email protected]> Change-Id: If703d2c20ceee4321520aa01a5b55c95e3c27113
This reverts commit c5cd333. Related to issues #9614 #9559 #9770 Signed-off-by: Szymon Kłos <[email protected]> Change-Id: I24967889c7b9a75d1afcdbdb67e04f45eaf230b6
timar
approved these changes
Aug 29, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This reverts subset of: #8011
Impact:
Related bugs on master:
#9614
#9559
#9770
It seems it fixes all of them, but breaks "polished look" of custom properties. Which is less damage.
cc: @meven @thebearon @timar